updates: python 3.11, new libczi #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 98.64% // Head: 98.64% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 3 3
Lines 148 148
=======================================
Hits 146 146
Misses 2 2 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
heeler
approved these changes
Feb 16, 2023
| @@ -3,4 +3,4 @@ | |||
| url = https://github.com/pybind/pybind11.git | |||
| [submodule "libCZI"] | |||
| path = libCZI | |||
| url = https://github.com/zeiss-microscopy/libCZI.git | |||
| url = https://github.com/ZEISS/libczi.git | |||
There was a problem hiding this comment.
This obviously works. An alternative is to use CMake's fetch_content methodology to pull the resource. In this case I don't think either has strong advantages.
evamaxfield
approved these changes
Feb 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update several dependencies, add build for python 3.11 and update libczi