Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shouldn't out arguments be returned values? #11

Closed
neclepsio opened this issue Sep 21, 2022 · 4 comments · Fixed by #65
Closed

Shouldn't out arguments be returned values? #11

neclepsio opened this issue Sep 21, 2022 · 4 comments · Fixed by #65
Labels
enhancement New feature or request

Comments

@neclepsio
Copy link
Contributor

For example:

func GetDrawCursorPos(pOut *ImVec2)

should be:

func GetDrawCursorPos() ImVec2
@AllenDang
Copy link
Owner

It's auto generated code, process arguments is a lot easier than recognize out value.

@sonoro1234
Copy link

sonoro1234 commented Oct 9, 2022 •
edited
Loading

this function have nonUDT=1 in definitions.json to let recognize it should be a return value

@AllenDang
Copy link
Owner

@sonoro1234 You could have a try and raise a PR

@sonoro1234
Copy link

sonoro1234 commented Oct 10, 2022 •
edited
Loading

Dont know go languaje.
Perhaps @neclepsio

https://github.com/sonoro1234/LuaJIT-ImGui/blob/00cbc2975a97723bb34f976f92d8dbc05a26a470/lua/imgui/glfw.lua#L5831

@gucio321 gucio321 added the enhancement New feature or request label Dec 3, 2022
gucio321 added a commit to gucio321/cimgui-go that referenced this issue Dec 14, 2022
@gucio321
codegen: return value instead taking pointer to it as an argument
54618aa 
fix AllenDang#11
@gucio321 gucio321 mentioned this issue Dec 14, 2022
Merged
@neclepsio neclepsio mentioned this issue Dec 15, 2022
Closed
@gucio321 gucio321 mentioned this issue Dec 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

codegen: return out value instead of taking pointer to it gucio321/cimgui-go
4 participants
@AllenDang @neclepsio @sonoro1234 @gucio321