Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split module to separated packages #319

Merged
merged 49 commits into from
Sep 24, 2024

Conversation

gucio321
Copy link
Collaborator

@gucio321 gucio321 commented Sep 21, 2024

Hi everyone!
Here I present a whole-new layout of cimgui-go.
This was discussed in, and will fix #25

Now, instead of having everything in cimgui-go package, there are 4 smaller packages for each plugin.
In theory, it also reduces build time as it allows to parallelize implot, imnodes and immarkdown build.

results on main:
real	2m32.649s
user	3m5.343s
sys	0m6.430s

on this PR

real	2m32.279s
user	3m6.522s
sys	0m6.435s

tested on ebiten example with time go build -a -v

@AllenDang this is a quite large change so I'll let you review and merge

@AllenDang AllenDang merged commit b688031 into AllenDang:main Sep 24, 2024
5 checks passed
@gucio321 gucio321 deleted the codegen-packages-support branch September 24, 2024 06:45
@gucio321
Copy link
Collaborator Author

@AllenDang maybe we should tag current master and publish some release as this pr is done is done?
I'd suggest v1.0.0 as I don't expect any backward-incompatible changes in the future, however we might want to wait with v1 for #224. If so we can release v0.1.0 which doesn't have to keep up with any compatibility rules.

@AllenDang
Copy link
Owner

@AllenDang maybe we should tag current master and publish some release as this pr is done is done? I'd suggest v1.0.0 as I don't expect any backward-incompatible changes in the future, however we might want to wait with v1 for #224. If so we can release v0.1.0 which doesn't have to keep up with any compatibility rules.

Agree, let's release v1.0.0!

@gucio321
Copy link
Collaborator Author

@AllenDang Release notes are ready. You should be able to see them.
Could you please take a look and check if everything is correct? https://github.com/AllenDang/cimgui-go/releases/tag/untagged-dff92b68e1384b851b54

@AllenDang
Copy link
Owner

@gucio321 Great work! I've read, awesome, looks everything is ready, please release it! Congratulations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Idea: move implot functions to a separate package
2 participants