Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: add github action for checking code on Pull Requests #45

Merged
merged 5 commits into from
Dec 12, 2022

Conversation

gucio321
Copy link
Collaborator

@gucio321 gucio321 commented Dec 3, 2022

No description provided.

@gucio321
Copy link
Collaborator Author

gucio321 commented Dec 3, 2022

okey, it fails since #43 - it meens that the issue's title "build: package seems to be broken and doesn't build anymore?" should be changed 😄

@gucio321
Copy link
Collaborator Author

gucio321 commented Dec 3, 2022

so after merging this, @AllenDang should go Settings->Branches
in "Branch protection rules" go to main and click Edit
tick "Require check status" and add this "RunGoTests" step

@AllenDang
Copy link
Owner

@gucio321 Got it. I will do that after this is merged.

@gucio321
Copy link
Collaborator Author

okey, @AllenDang @eliasdaler so this one compiles and can be reviewed!

.github/workflows/test.yaml Outdated Show resolved Hide resolved
.github/workflows/test.yaml Outdated Show resolved Hide resolved
@eliasdaler eliasdaler merged commit b74c9b0 into AllenDang:main Dec 12, 2022
@gucio321 gucio321 deleted the test-workflow branch December 12, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants