Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: change package name cimgui -> imgui #81

Merged
merged 1 commit into from
Jan 10, 2023
Merged

proposal: change package name cimgui -> imgui #81

merged 1 commit into from
Jan 10, 2023

Conversation

gucio321
Copy link
Collaborator

@gucio321 gucio321 commented Jan 9, 2023

Hi there!
I've changed package name from cimgui to imgui
so it it looks as follows:

import "github.com/AllenDang/cimgui-go" // no changes here

// but when refering to package, it is called `imgui`
imgui.InputText(...)

@AllenDang @eliasdaler let me know whether we want this change 😄

AllenDang
AllenDang approved these changes Jan 10, 2023
View reviewed changes
Copy link
Owner

@AllenDang AllenDang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gucio321 gucio321 merged commit a4962b3 into AllenDang:main Jan 10, 2023
@gucio321 gucio321 deleted the package-name branch January 10, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllenDang AllenDang AllenDang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gucio321 @AllenDang