-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paging shows 'There is no data to display' when data is exists #125
Comments
It's seem like a bug, did you use |
I am using simple array without any wraps. I've opened state of PaginationList component in React DevTools and saw that after reducing array size the currentPage property in component state is out of array size |
OK, thanks, I'll fix it in recent. |
@iamyardem, about your 4th item(Delete 20 elements from dataSource invoking some function (e.g. apply some filtering or something)), you means you delete 20 elements by yourself function? because I try your scenario, I got some error, not 'There is no data to display'. That my steps:
Anyway, I'll fix the problem but I'm not sure my problem is actually you encountered before. |
@AllenFang in my case we are using property passed from redux to component as data source. and we have let say a search button which calls a function which searches data by some criteria and bind new result to component property. So when this property changes after clicking button, render method bind new result to table grid again, but after render, pagination keeps observing last visited page despite the array size is less then page-index*page-elem-count |
I understand, thanks :) |
@iamyardem, could you try the newest version v1.2.8 again? I did some change, but I'm not sure this patch whether could solve |
@AllenFang thanks, it looks like it is fixed now |
really? |
if change to page one when data reload, I need to do some little improvements, because page one button does not actived |
anyway it redirects to 1-st page as expected and no data loss which is great :) |
Great, I'll do more improvements, thank you :) |
thank you too for your effort :) |
Are you sure that this issue is closed? I am still getting this error when displaying data with pagination. Without pagination, however, the error is not displayed. My data is over 100 entries big. The code is as follows:
|
what kind of error? and I just check it in my local with same configuration, it work well. so maybe please provide more information if you have |
@saisivaram94 did you update your package successfully? My issue #1232 was resolved for me after I updated to the latest version. |
sure, please upgrade to newest version. thanks @Anima-t3d |
@AllenFang - I am so so sorry for the late reply. I had some urgent deadlines to meet at work, so I couldn't make time. I am attaching the snapshots of both the scenarios. In one, I am using pagination and in the other, I am not. As you can see, with the paginated display, I get no search results. But in the non-paginated version, I get the exact search result. Moreover, after clearing the search field in the paginated version, I do not get the original table back. By that I mean, if I search anything when I am on page 1, then after clearing the search field I do not get the data on page 1 back. I need to load another page and then again come back to Page 1 to get the data. @Anima-t3d - I installed this package just 2 days ago, the same day that I made the comment. I am running v3.2.0 |
Ok. I updated the package now and it seems to be working fine. |
Steps to reproduce:
It looks like paging just keep observing 3-rd page expecting that dataSource still has 30 elements or more. Maybe need to reset page to the 1-st page or default page in case of changing dataSource?
Is there any quick solution we can use with existing api? Or maybe I am doing something wrong... Anyway, looking forward your reply. Thanks!
If you need more details, I'll try to provide some examples.
The text was updated successfully, but these errors were encountered: