Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass column.attrs to TableEditColumn #1478

Closed
MekMed opened this issue Jul 13, 2017 · 9 comments
Closed

pass column.attrs to TableEditColumn #1478

MekMed opened this issue Jul 13, 2017 · 9 comments
Labels
4.0.0 help wanted in progress

Comments

@MekMed
Copy link

MekMed commented Jul 13, 2017

Actually, the column.attrs is not passed to the TableEditColumn class.
As consequence, when specifying 'colspan' for example, it is not add in the TableEditColumn.

Is it possible to add column.attrs to the current TableEditColumn on's ?

Thx,
@AllenFang
Copy link
Owner

AllenFang commented Jul 14, 2017 •
edited
Loading

@MekMed, we have a PR is working on it #1464
But it only for v4.0.0 but it still on beta.

@MekMed
Copy link
Author

MekMed commented Jul 14, 2017

Ok, Good.
I'll wait for v4.0.0.
Thx for your work

Issue closed.

@MekMed MekMed closed this as completed Jul 14, 2017
AllenFang added a commit that referenced this issue Jul 16, 2017
@AllenFang
example for #1478
a864f82
@AllenFang
Copy link
Owner

@MekMed this was fixed and released on [v4.0.0-beta.8](this PR was fixed and released on `v4.0.0-beta.8, check this commit to learn how to add your own attributes on editor, thanks

Let me know if you have any questions

@MekMed
Copy link
Author

MekMed commented Jul 17, 2017

@AllenFang thanx for your fix. However, attributes are actually settled to the field inside the 'td' element. But, for the 'colspan', it must be settled to the 'td'. Is it possible to have an attribute 'tdAttr' like for the TableHeaderColumn ?

thx,

@MekMed MekMed reopened this Jul 17, 2017
@AllenFang
Copy link
Owner

@MekMed sorry, I misunderstand your requirement, I will find some way to add attributes on td, thanks

trongthanh added a commit to goalifyplus/react-bootstrap-table that referenced this issue Jul 18, 2017
@trongthanh
Merge commit 'c7ab34cabb40a66fe237a12413cb31798cdb4ff1'
1cbe576 
* commit 'c7ab34cabb40a66fe237a12413cb31798cdb4ff1': (32 commits)
  v4.0.0-beta.8
  prod
  example for AllenFang#1478
  refine for setting attributes on editor
  example for AllenFang#1423
  fix bug for wrong select options
  add ref and event handling
  simplify combining attrs
  allow setting attrs on editable cells
  v4.0.0-beta.7
  prod
  Dynamic options list in Editable select column AllenFang#1423 Still missing support for insert dialog.
  v4.0.0-beta.6
  prod
  remove redundant state
  issue-1130: added show to make size dropdown compatible with bootstrap4
  v4.0.0-beta.5
  prod
  replace React.PropTypes with `prop-types`
  replace PropTypes with `prop-types` library to remove warnings
  ...
AllenFang added a commit that referenced this issue Jul 31, 2017
@AllenFang
fix #1478, use editTdAttr to add attribute to TD when cell editing
42e84b7
@AllenFang
Copy link
Owner

AllenFang commented Aug 1, 2017 •
edited
Loading

@MekMed this was fixed on v4.0.0-beta.9, use editTdAttr on TableHeaderColumn instead. Thanks

@MekMed
Copy link
Author

MekMed commented Aug 11, 2017

@AllenFang It is working fine 👍 . Thx a lot for your work.

@AllenFang
Copy link
Owner

@MekMed thanks, BTW, v4.0.0 has been released, you can check this 👍

@rajinikala
Copy link

Can some one post a usage of editTdAttr ? Much appreciated !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.0.0 help wanted in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AllenFang @MekMed @rajinikala