Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use btn-primary for the Save button #527

Merged
merged 2 commits into from
Aug 2, 2016
Merged

Conversation

scharf
Copy link
Contributor

@scharf scharf commented Jun 22, 2016

The save button is not an informational alert message but rather ... a successful or positive action. This can confuse users.

See the bootstrap documentation for the button classes:

<!-- Indicates a successful or positive action -->
<button type="button" class="btn btn-success">Success</button>

<!-- Contextual button for informational alert messages -->
<button type="button" class="btn btn-info">Info</button>

see http://getbootstrap.com/css/#buttons-options

The save button is not a `informational alert message`... This can confuse users.

```html
<!-- Indicates a successful or positive action -->
<button type="button" class="btn btn-success">Success</button>

<!-- Contextual button for informational alert messages -->
<button type="button" class="btn btn-info">Info</button>
```
@scharf
Copy link
Contributor Author

scharf commented Jun 22, 2016

Hmm, maybe btn-primary is even a better choice for this button, because this is the primary action....

<!-- Provides extra visual weight and identifies the primary action in a set of buttons -->
<button type="button" class="btn btn-primary">Primary</button>

@scharf scharf changed the title Use btn-success for the Save button Use btn-primary for the Save button Jun 22, 2016
@AllenFang
Copy link
Owner

@scharf, thanks your contribution :)

@AllenFang AllenFang merged commit a7923b4 into AllenFang:master Aug 2, 2016
@AllenFang
Copy link
Owner

Released on v2.4.0. Thanks your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants