Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework SF labnotebook and add anaFuncParam #2061

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

t-b
Copy link
Collaborator

@t-b t-b commented Mar 13, 2024

Example code:

sel = select(channels(AD), sweeps())

labnotebook(["USER_DA Scale f-I slope", "USER_DA Scale BL QC"], $sel, UNKNOWN_MODE)

and

AnaFuncParam(["MaxFrequencyChangePercent", "AbsFrequencyMinDistance", "AbsDAScaleMinDistance", "AbsDAScaleMaxDistance"], $sel)

and

AnaFuncParam("OperationMode")

Close #1845

@t-b t-b mentioned this pull request Mar 13, 2024
@t-b
Copy link
Collaborator Author

t-b commented Mar 13, 2024

@timjarsky THis has the changes for accepting multiple labnotebook keys and the new anaFuncParam operation. See above for examples.

@timjarsky

This comment was marked as outdated.

@t-b t-b self-assigned this Mar 14, 2024
@timjarsky
Copy link
Collaborator

@t-b nice!

image

@t-b t-b force-pushed the feature/2061-sf-labnotebook-anafuncparam branch 2 times, most recently from a07c84e to e27b767 Compare March 26, 2024 13:24
@t-b
Copy link
Collaborator Author

t-b commented Mar 26, 2024

Next revision:

Code:

sci = [10, 11, 12]
sel = select(channels(AD), $sci, all)

data($ep, $sel)

and

labnotebook(["Delay onset auto", "Delay onset user"], $sel, UNKNOWN_MODE)

and

AnaFuncParam(["*"], $sel)

and

AnaFuncParam(["SlopePercentage", "SamplingFrequency"], $sel)

grafik

We now have unique colors per sweep if all data is from the same channelType and number, and also wildcard support for anaFuncParam. Without that there is no way to figure out what parameters are available.

And we have better y-axis labels for labnotebook data including units.

@timjarsky If that is good, I'll polish it.

@t-b

This comment was marked as outdated.

@t-b t-b force-pushed the feature/2061-sf-labnotebook-anafuncparam branch from 8069e16 to 9bfd5d4 Compare April 18, 2024 19:59
@t-b t-b force-pushed the feature/2061-sf-labnotebook-anafuncparam branch from 9bfd5d4 to 8b7f469 Compare June 7, 2024 13:15
@t-b t-b mentioned this pull request Jun 12, 2024
@t-b t-b force-pushed the feature/2061-sf-labnotebook-anafuncparam branch from 8b7f469 to 9852a44 Compare July 12, 2024 11:28
@t-b t-b force-pushed the feature/2061-sf-labnotebook-anafuncparam branch 2 times, most recently from 8548cdc to 6c0b1d1 Compare September 10, 2024 21:21
@t-b t-b force-pushed the feature/2061-sf-labnotebook-anafuncparam branch 2 times, most recently from ad4beec to 2725ca1 Compare September 13, 2024 11:59
@t-b t-b assigned timjarsky and unassigned t-b Sep 13, 2024
@t-b t-b marked this pull request as ready for review September 13, 2024 11:59
The operation now supports multiple keys given as array and wildcards as
part of the key.

In addition we now add a per trace legend entry with a custom marker.
Included is also the unit, for binary units we create special y axis
ticks.
We now allow SF operations to say which traces should have the same
colors in the plotter. This allows to have sweep data plotted where the
color is the same for each channel type/number.
For plots like the labnotebook or the analysis function parameters it is
easily possible that one has multiple traces with more or less the same
x and y values. And for these cases it is difficult to distinguish the
entries.

We now have a custom window hook which creates a tooltip with the names
and values of the labnotebook/analysis function parameter.
@t-b t-b force-pushed the feature/2061-sf-labnotebook-anafuncparam branch from 2725ca1 to dc25e1e Compare September 13, 2024 18:22
@t-b
Copy link
Collaborator Author

t-b commented Sep 13, 2024

I've implemented the tooltip for labnotebook and anaFuncParam as it is quite helpful.

@timjarsky
Copy link
Collaborator

slick! Thanks @t-b

image

@timjarsky timjarsky assigned t-b and unassigned timjarsky Sep 16, 2024
@timjarsky
Copy link
Collaborator

@t-b I'm seeing the data plotting style change in the middle of the plot. It seems like the method for changing the style depending on the number of points is being applied to the same plot

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SweepFormula: Use different colors for traces from data
2 participants