New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reset should set vr to zero #8

Merged

Allenxuxu merged 1 commit into Allenxuxu:master from sunfuze:fix-reset

Nov 2, 2021

Contributor

sunfuze commented Nov 2, 2021 •

edited

Loading

WithData and Reset should reset vr to zero, or reuse ringbuffer raise slice outrange read.

gev if here handle protocol data have remains vr value, next time reuse c.buffer the vr is not equals to r then do VirtualRead will raise error.


          reset should set vr to zero

2c3b489

Owner

Allenxuxu commented Nov 2, 2021

WithData and Reset should reset vr to zero, or reuse ringbuffer raise slice outrange read.

gev if here handle protocol data have remains vr value, next time reuse c.buffer the vr is not equals to r then do VirtualRead will raise error.

Thank you very much, there is a bug. Would you like to create an PR for gev to fix this issue ?

Allenxuxu added the bug label

Allenxuxu merged commit 7371440 into Allenxuxu:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug