-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add buildx support for build-docker.sh #16822
Add buildx support for build-docker.sh #16822
Conversation
@beinan Would you like to take a look~Thanks♪(・ω・)ノ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in case others are using the same script, can we preserve backwards compatibility by setting the most common default value for build_mode
and platform
, such that if the script was called as before (ex. dev/scripts/build-docker.sh path/to/tarball
) it will still operate as before?
Makes sense, I'll modify it |
Before this PR, build-docker.sh does not support setting parameters, so there is no backward compatibility issue on parameters. After the second commit is modified, it will be consistent with the previous image tag without specifying buildx. |
alluxio-bot, merge this please |
### What changes are proposed in this pull request? Fix Alluxio#16821 Developers can execute cross compare with `build-docker.sh` etc. `./build-docker.sh buildx linux/arm64` ### Why are the changes needed? Nope. ### Does this PR introduce any user facing changes? Nope, just for developers. pr-link: Alluxio#16822 change-id: cid-736afb945b565d6756fa671e257a67d1db5e408a
What changes are proposed in this pull request?
Fix #16821
Developers can execute cross compare with
build-docker.sh
etc.
./build-docker.sh buildx linux/arm64
Why are the changes needed?
Nope.
Does this PR introduce any user facing changes?
Nope, just for developers.