Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded version dependency in examples module #16844

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Remove hardcoded version dependency in examples module #16844

merged 2 commits into from
Feb 15, 2023

Conversation

maobaolong
Copy link
Contributor

@maobaolong maobaolong commented Feb 3, 2023 •
edited
Loading

Fix the security issue introduced by following link. The newest version of hadoop fix this issue.

I remove the hadoop.version property to keep consistent with parent module.

@LuQQiu
Copy link
Contributor

LuQQiu commented Feb 7, 2023

@maobaolong is it a in-progress PR?

@maobaolong maobaolong closed this Feb 10, 2023
@maobaolong maobaolong reopened this Feb 10, 2023
@maobaolong
Copy link
Contributor Author

@LuQQiu No, this is ready for review, PTAL

@maobaolong
Copy link
Contributor Author

@jiacheliu3 The description has been updated.

@maobaolong maobaolong mentioned this pull request Feb 13, 2023
Merged
huanghua78
huanghua78 approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@huanghua78 huanghua78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jiacheliu3 jiacheliu3 changed the title Fix hadoop security issue Remove hardcoded version dependency in examples module Feb 13, 2023
jiacheliu3
jiacheliu3 approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@jiacheliu3 jiacheliu3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@jiacheliu3
Copy link
Contributor

alluxio-bot, merge this please

@alluxio-bot
Copy link
Contributor

Check evaluation failed:
Github action modules: (alluxio.client.,alluxio.master.) concluded as failure, which is not success or skipped

@jiacheliu3
Copy link
Contributor

@Xenorith not sure if you seen this before, all checks are green but the bot doesn't seem to realize. I'll just force merge?

Check evaluation failed: Github action modules: (alluxio.client.,alluxio.master.) concluded as failure, which is not success or skipped

image

@jiacheliu3
Copy link
Contributor

Lemme rerun alluxio.client.*, alluxio.master.* and see if the bot sees this time.

@jiacheliu3
Copy link
Contributor

oops there's a conflict introduced by another PR, do you mind doing a rebase? @maobaolong Thanks!

@Xenorith
Copy link
Contributor

@Xenorith not sure if you seen this before, all checks are green but the bot doesn't seem to realize. I'll just force merge?

Check evaluation failed: Github action modules: (alluxio.client.,alluxio.master.) concluded as failure, which is not success or skipped

image

yeah it's strange that there can be build failures when i make this check through the API but it's not showing here on the UI. second time i've seen it. if you can confirm this is the case for future PRs, feel free to make use of force-merge

@maobaolong
Copy link
Contributor Author

@jiacheliu3 @huanghua78 The conflict has been resolved, PTAL.

@jiacheliu3
Copy link
Contributor

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 6e8e0dc into Alluxio:master Feb 15, 2023
jiacheliu3 pushed a commit to jiacheliu3/alluxio that referenced this pull request May 16, 2023
@maobaolong @jiacheliu3
Remove hardcoded version dependency in examples module
f689dee 
Fix the security issue introduced by following link. The newest version
of hadoop fix this issue.

- http://horus.oa.com/advisory/HOSA-pzst-tfwm6u4cy
- http://horus.oa.com/advisory/HOSA-n612-2d07um3px
- http://horus.oa.com/advisory/HOSA-yn2x-x9qulrobf
- http://horus.oa.com/advisory/HOSA-jatn-nizpv9w2u

I remove the hadoop.version property to keep consistent with parent
module.

pr-link: Alluxio#16844
change-id: cid-b9e60f612d667b0ae3daea1314593a284b65b622
jiacheliu3 pushed a commit to jiacheliu3/alluxio that referenced this pull request May 16, 2023
@maobaolong @jiacheliu3
Remove hardcoded version dependency in examples module
25ebb95 
Fix the security issue introduced by following link. The newest version
of hadoop fix this issue.

- http://horus.oa.com/advisory/HOSA-pzst-tfwm6u4cy
- http://horus.oa.com/advisory/HOSA-n612-2d07um3px
- http://horus.oa.com/advisory/HOSA-yn2x-x9qulrobf
- http://horus.oa.com/advisory/HOSA-jatn-nizpv9w2u

I remove the hadoop.version property to keep consistent with parent
module.

pr-link: Alluxio#16844
change-id: cid-b9e60f612d667b0ae3daea1314593a284b65b622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huanghua78 huanghua78 huanghua78 approved these changes

@jiacheliu3 jiacheliu3 jiacheliu3 approved these changes

Assignees

@LuQQiu LuQQiu

Labels
POM Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maobaolong @LuQQiu @jiacheliu3 @alluxio-bot @Xenorith @huanghua78