Make version service return unavailable on standby masters #16854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
overall LGTM. Should we revert the change about |
jiacheliu3
approved these changes
Feb 12, 2023
| } | ||
|
|
||
| @Override | ||
| @SuppressFBWarnings(value = "DB_DUPLICATE_SWITCH_CLAUSES") | ||
| public void getServiceVersion(GetServiceVersionPRequest request, | ||
| StreamObserver<GetServiceVersionPResponse> responseObserver) { | ||
| if (mStandbyRpcEnabled | ||
| && mNodeStateSupplier != null && mNodeStateSupplier.get() == NodeState.STANDBY) { |
There was a problem hiding this comment.
nit: what does mNodeStateSupplier == null imply?
There was a problem hiding this comment.
the grpc service is on worker
Let's keep it as is. Adding this does not do harm. |
|
alluxio-bot, merge this please |
alluxio-bot
pushed a commit
that referenced
this pull request
Feb 16, 2023
### What changes are proposed in this pull request? Add a rejectOnStandbyMasters on version grpc endpoint ### Why are the changes needed? We added a PR to make standby master return unavailable on this version service endpoint #16854 However, in addition to the polling master inquire client, the AbstractMasterClient also needs this endpoint. https://github.com/Alluxio/alluxio/blob/master/core/common/src/main/java/alluxio/AbstractClient.java#L172 When a client makes a request to standby master, such check will constantly fail and resulted in failures. So we want the logic done in #16854 only applies to PollingMasterInquireClient and hence we added this boolean field to bypass the check. ### Does this PR introduce any user facing changes? N/A pr-link: #16890 change-id: cid-379f8af78250d2a230bceff9d7ea75739979e198
bzheng888
pushed a commit
to bzheng888/alluxio
that referenced
this pull request
Mar 8, 2023
### What changes are proposed in this pull request? Make version service return unavailable on standby masters ### Why are the changes needed? In this Alluxio#16839 PR, we adds the capability to run grpc services on standby masters. However, if one uses an old alluxio client and connects to the new master with standby master enabled, it will get some errors. This PR is used to address the issue to make the change backward compatible. ### Does this PR introduce any user facing changes? N/A pr-link: Alluxio#16854 change-id: cid-6c82bce1b1d6cb2649658ec09f0f8ed4e243917a (cherry picked from commit 7399c38)
bzheng888
pushed a commit
to bzheng888/alluxio
that referenced
this pull request
Mar 8, 2023
### What changes are proposed in this pull request? Add a rejectOnStandbyMasters on version grpc endpoint ### Why are the changes needed? We added a PR to make standby master return unavailable on this version service endpoint Alluxio#16854 However, in addition to the polling master inquire client, the AbstractMasterClient also needs this endpoint. https://github.com/Alluxio/alluxio/blob/master/core/common/src/main/java/alluxio/AbstractClient.java#L172 When a client makes a request to standby master, such check will constantly fail and resulted in failures. So we want the logic done in Alluxio#16854 only applies to PollingMasterInquireClient and hence we added this boolean field to bypass the check. ### Does this PR introduce any user facing changes? N/A pr-link: Alluxio#16890 change-id: cid-379f8af78250d2a230bceff9d7ea75739979e198 (cherry picked from commit da6abf7)
YangchenYe323
pushed a commit
to YangchenYe323/alluxio
that referenced
this pull request
Apr 16, 2023
### What changes are proposed in this pull request? Add a rejectOnStandbyMasters on version grpc endpoint ### Why are the changes needed? We added a PR to make standby master return unavailable on this version service endpoint Alluxio#16854 However, in addition to the polling master inquire client, the AbstractMasterClient also needs this endpoint. https://github.com/Alluxio/alluxio/blob/master/core/common/src/main/java/alluxio/AbstractClient.java#L172 When a client makes a request to standby master, such check will constantly fail and resulted in failures. So we want the logic done in Alluxio#16854 only applies to PollingMasterInquireClient and hence we added this boolean field to bypass the check. ### Does this PR introduce any user facing changes? N/A pr-link: Alluxio#16890 change-id: cid-379f8af78250d2a230bceff9d7ea75739979e198
jiacheliu3
pushed a commit
to jiacheliu3/alluxio
that referenced
this pull request
May 16, 2023
### What changes are proposed in this pull request? Make version service return unavailable on standby masters ### Why are the changes needed? In this Alluxio#16839 PR, we adds the capability to run grpc services on standby masters. However, if one uses an old alluxio client and connects to the new master with standby master enabled, it will get some errors. This PR is used to address the issue to make the change backward compatible. ### Does this PR introduce any user facing changes? N/A pr-link: Alluxio#16854 change-id: cid-6c82bce1b1d6cb2649658ec09f0f8ed4e243917a
jiacheliu3
pushed a commit
to jiacheliu3/alluxio
that referenced
this pull request
May 16, 2023
### What changes are proposed in this pull request? Add a rejectOnStandbyMasters on version grpc endpoint ### Why are the changes needed? We added a PR to make standby master return unavailable on this version service endpoint Alluxio#16854 However, in addition to the polling master inquire client, the AbstractMasterClient also needs this endpoint. https://github.com/Alluxio/alluxio/blob/master/core/common/src/main/java/alluxio/AbstractClient.java#L172 When a client makes a request to standby master, such check will constantly fail and resulted in failures. So we want the logic done in Alluxio#16854 only applies to PollingMasterInquireClient and hence we added this boolean field to bypass the check. ### Does this PR introduce any user facing changes? N/A pr-link: Alluxio#16890 change-id: cid-379f8af78250d2a230bceff9d7ea75739979e198
jiacheliu3
pushed a commit
to jiacheliu3/alluxio
that referenced
this pull request
May 16, 2023
### What changes are proposed in this pull request? Make version service return unavailable on standby masters ### Why are the changes needed? In this Alluxio#16839 PR, we adds the capability to run grpc services on standby masters. However, if one uses an old alluxio client and connects to the new master with standby master enabled, it will get some errors. This PR is used to address the issue to make the change backward compatible. ### Does this PR introduce any user facing changes? N/A pr-link: Alluxio#16854 change-id: cid-6c82bce1b1d6cb2649658ec09f0f8ed4e243917a
jiacheliu3
pushed a commit
to jiacheliu3/alluxio
that referenced
this pull request
May 16, 2023
### What changes are proposed in this pull request? Add a rejectOnStandbyMasters on version grpc endpoint ### Why are the changes needed? We added a PR to make standby master return unavailable on this version service endpoint Alluxio#16854 However, in addition to the polling master inquire client, the AbstractMasterClient also needs this endpoint. https://github.com/Alluxio/alluxio/blob/master/core/common/src/main/java/alluxio/AbstractClient.java#L172 When a client makes a request to standby master, such check will constantly fail and resulted in failures. So we want the logic done in Alluxio#16854 only applies to PollingMasterInquireClient and hence we added this boolean field to bypass the check. ### Does this PR introduce any user facing changes? N/A pr-link: Alluxio#16890 change-id: cid-379f8af78250d2a230bceff9d7ea75739979e198
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Make version service return unavailable on standby masters
Why are the changes needed?
In this #16839 PR, we adds the capability to run grpc services on standby masters. However, if one uses an old alluxio client and connects to the new master with standby master enabled, it will get some errors. This PR is used to address the issue to make the change backward compatible.
Does this PR introduce any user facing changes?
N/A