Replace ManagementFactoryHelper with ManagementFactory for java11

[yyongycy]

What changes are proposed in this pull request?

Replace ManagementFactoryHelper with ManagementFactory for java11

Why are the changes needed?

Java 11 doesn't support to directly call ManagementFactoryHelper, so it is necessary to find an alternative one in java11.

Does this PR introduce any user facing changes?

NA

[Xenorith]

were you able to run some code with this change in a java 11 environment?

for example, you could use the docker image at https://hub.docker.com/layers/alluxio/alluxio-maven/0.0.8-jdk11/images/sha256-84e7253045d53cc2ebfce98e3d6710b1d446e9724115df3dbf4bf41935b25d7c?context=explore as a way to run some of the same maven commands as the PR checks

[yyongycy]

were you able to run some code with this change in a java 11 environment?

for example, you could use the docker image at https://hub.docker.com/layers/alluxio/alluxio-maven/0.0.8-jdk11/images/sha256-84e7253045d53cc2ebfce98e3d6710b1d446e9724115df3dbf4bf41935b25d7c?context=explore as a way to run some of the same maven commands as the PR checks

So still no chance to compile, am I right?

I have a small program to try with java11:

import java.lang.management.BufferPoolMXBean;
import java.lang.management.ManagementFactory;
import java.lang.management.MemoryPoolMXBean;
import java.nio.ByteBuffer;

public class JavaExceptionTest {

public static void main(String[] args) {
BufferPoolMXBean memoryPoolMXBean = getDirectBuffer();
System.out.println("Got bean:" + memoryPoolMXBean);
System.out.println(String.format("DirectMem used: %d", memoryPoolMXBean.getMemoryUsed()));
ByteBuffer.allocateDirect(5);
System.out.println(String.format("DirectMem used: %d", memoryPoolMXBean.getMemoryUsed()));
}

private static BufferPoolMXBean getDirectBuffer() {
for (BufferPoolMXBean bufferPoolMXBean
: java.lang.management.ManagementFactory.getPlatformMXBeans(BufferPoolMXBean.class)) {
System.out.println(String.format("found pool: %s %s",
bufferPoolMXBean, bufferPoolMXBean.getName()));
if (bufferPoolMXBean.getName().equals("direct")) {
return bufferPoolMXBean;
}
}
return null;
}
}

[yyongycy]

Following is the commands:

alluxio@MacBook-Pro-3 java % java -version
openjdk version "11.0.2" 2019-01-15
OpenJDK Runtime Environment 18.9 (build 11.0.2+9)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.2+9, mixed mode)
alluxio@MacBook-Pro-3 java % javac JavaExceptionTest.java
alluxio@MacBook-Pro-3 java % java JavaExceptionTest
found pool: sun.management.ManagementFactoryHelper$1@13fee20c mapped
found pool: sun.management.ManagementFactoryHelper$1@4e04a765 direct
Got bean:sun.management.ManagementFactoryHelper$1@4e04a765
DirectMem used: 0
DirectMem used: 5

[Xenorith]

were you able to run some code with this change in a java 11 environment?
for example, you could use the docker image at https://hub.docker.com/layers/alluxio/alluxio-maven/0.0.8-jdk11/images/sha256-84e7253045d53cc2ebfce98e3d6710b1d446e9724115df3dbf4bf41935b25d7c?context=explore as a way to run some of the same maven commands as the PR checks

So still no chance to compile, am I right?

You would be able to compile the code within the docker container with java 8 and then run the maven commands with java 11. This follows the way we build the code and run it on a different java version since we always build with java 8 and only test compatibility with other java versions at runtime.

[yyongycy]

@Xenorith this is to try with jdk11,

[yyongycy]

Once all tests pass, I will revert this change.

[yyongycy]

Once all tests pass, I will revert this change.

[yyongycy]

were you able to run some code with this change in a java 11 environment?
for example, you could use the docker image at https://hub.docker.com/layers/alluxio/alluxio-maven/0.0.8-jdk11/images/sha256-84e7253045d53cc2ebfce98e3d6710b1d446e9724115df3dbf4bf41935b25d7c?context=explore as a way to run some of the same maven commands as the PR checks

So still no chance to compile, am I right?

You would be able to compile the code within the docker container with java 8 and then run the maven commands with java 11. This follows the way we build the code and run it on a different java version since we always build with java 8 and only test compatibility with other java versions at runtime.

Verified with the container,

[yyongycy]

alluxio-bot, merge this please