Support getFileBlockLocation in LocalCacheFileSystem #17672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maobaolong
changed the title
|
Automated checks report:
Some checks failed. Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks. |
…ernal file system
maobaolong
force-pushed
the
localcacheblocklocation
branch
from
a3532fd
to
aeb7ee2
Compare
maobaolong
changed the title
|
Automated checks report:
All checks passed! |
|
Can you please describe what are the benefits if the client can get access to the block location info? Would that cause the client to directly talk to the datanode and bypass local cache? |
|
@dbw9580 The compute framework can use it to schedule the split task to the node in the same block location. |
jiacheliu3
reviewed
Jul 7, 2023
| @Override | ||
| public BlockLocation[] getFileBlockLocations(FileStatus file, long start, | ||
| long len) throws IOException { | ||
| return mExternalFileSystem.getFileBlockLocations(file, start, len); |
There was a problem hiding this comment.
// Applications use the block information here to schedule/distribute the tasks.
// Return the UFS locations directly instead of the local cache location,
// so the application can schedule the tasks accordingly
There was a problem hiding this comment.
@dbw9580 @maobaolong what do you think about this?
|
@jiacheliu3 Thanks for your suggested comments, PTAL. |
dbw9580
approved these changes
Jul 24, 2023
|
alluxio-bot, merge this please |
jiacheliu3
pushed a commit
to jiacheliu3/alluxio
that referenced
this pull request
Nov 8, 2023
### What changes are proposed in this pull request? Delegate `getFileBlockLocation` to external file system in `LocalCacheFileSystem`. ### Why are the changes needed? Otherwise, `LocalCacheFileSystem` inherits the default behavior of `org.apache.hadoop.fs.FileSystem` which returns `localhost` only. ### Does this PR introduce any user facing changes? No. pr-link: Alluxio#17672 change-id: cid-eb545dbd8ed42001d074fecfb9c8d6b118a559c1
ssz1997
pushed a commit
to ssz1997/alluxio
that referenced
this pull request
Dec 15, 2023
### What changes are proposed in this pull request? Delegate `getFileBlockLocation` to external file system in `LocalCacheFileSystem`. ### Why are the changes needed? Otherwise, `LocalCacheFileSystem` inherits the default behavior of `org.apache.hadoop.fs.FileSystem` which returns `localhost` only. ### Does this PR introduce any user facing changes? No. pr-link: Alluxio#17672 change-id: cid-eb545dbd8ed42001d074fecfb9c8d6b118a559c1
maobaolong
added a commit
to maobaolong/alluxio
that referenced
this pull request
Jan 3, 2024
### What changes are proposed in this pull request? Delegate `getFileBlockLocation` to external file system in `LocalCacheFileSystem`. ### Why are the changes needed? Otherwise, `LocalCacheFileSystem` inherits the default behavior of `org.apache.hadoop.fs.FileSystem` which returns `localhost` only. ### Does this PR introduce any user facing changes? No. pr-link: Alluxio#17672 change-id: cid-eb545dbd8ed42001d074fecfb9c8d6b118a559c1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Delegate
getFileBlockLocationto external file system inLocalCacheFileSystem.Why are the changes needed?
Otherwise,
LocalCacheFileSysteminherits the default behavior oforg.apache.hadoop.fs.FileSystemwhich returnslocalhostonly.Does this PR introduce any user facing changes?
No.