Create DoraWorkerServiceHandlerTest.java #18059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update Rename and exists tests for PagedDoraWorker.
elega
reviewed
Aug 25, 2023
|
|
||
| @Override | ||
| public void onCompleted() { | ||
| // do nothing |
elega
reviewed
Aug 25, 2023
| @Override | ||
| public void onCompleted() { | ||
| // do nothing | ||
| mResponses.sort(Comparator.comparing(MyStruct::getPath)); |
There was a problem hiding this comment.
sort in the test instead of sorting in this test observer
elega
reviewed
Aug 25, 2023
| TestStreamObserver responseObserver = new TestStreamObserver(); | ||
| mServiceHandler.listStatus(mRequest, responseObserver); | ||
| List<MyStruct> responses = responseObserver.mResponses; | ||
| String[] expectedPaths = new String[] {rootPath + "/d1", rootPath + "/d1/d1", |
elega
reviewed
Aug 25, 2023
| TestStreamObserver finalResponseObserver = responseObserver; | ||
| assertThrows(RuntimeException.class, () -> mServiceHandler.listStatus(mRequest, | ||
| finalResponseObserver)); | ||
| } |
There was a problem hiding this comment.
- list a file
- list a directory that does not exist
elega
reviewed
Aug 25, 2023
| } | ||
|
|
||
| @Test | ||
| public void testListStatus() throws IOException { |
There was a problem hiding this comment.
also test InAlluxioPercentage
|
Automated checks report:
Some checks failed. Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks. |
thu-david
changed the title
|
Automated checks report:
All checks passed! |
elega
reviewed
Aug 28, 2023
| } | ||
|
|
||
| @Test | ||
| public void testListStatus() throws IOException { |
There was a problem hiding this comment.
can you create different tests instead?
elega
reviewed
Aug 28, 2023
| fos.close(); | ||
|
|
||
| AlluxioURI oldPath = TEST_FILE_URI; | ||
| for (int i = 1; i < 10; i++) { |
|
alluxio-bot, merge this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
I have created a test and create a liststatus test for its function.
Why are the changes needed?
Please clarify why the changes are needed. For instance,
add a unit test for DoraWorkerClientServiceHandler.
Does this PR introduce any user facing changes?
No.