Extract path resolution in DoraCacheFS into static utility #18140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacheliu3
changed the title
dbw9580
reviewed
Sep 13, 2023
| } | ||
|
|
||
| // Treat this path as Alluxio relative, and add the UFS root before it. | ||
| String ufsFullPath = PathUtils.concatPath(ufsRootPath, alluxioPath.toString()); |
There was a problem hiding this comment.
Suggested change
| String ufsFullPath = PathUtils.concatPath(ufsRootPath, alluxioPath.toString()); | |
| String ufsFullPath = PathUtils.concatPath(ufsRootPath, alluxioPath.getPath()); |
| if (alluxioPath.isRoot()) { | ||
| ufsFullPath = ufsFullPath + AlluxioURI.SEPARATOR; | ||
| } |
There was a problem hiding this comment.
what is this supposed to do?
There was a problem hiding this comment.
i don't know, this is a refactor
|
The only errors are |
jiacheliu3
force-pushed
the
extract-utility
branch
from
119e460
to
2c6166a
Compare
|
alluxio-bot, merge this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
In this change the path conversion logic is extracted to static utility methods for code reuse (because other classes may use the same path resolution logic).
The method names are slightly improved, to distinguish the member methods in
DoraCacheFileSystem(may be inherited) from the static utility methods.