Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add datePredicate #18155

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Add datePredicate #18155

merged 1 commit into from
Sep 18, 2023

Conversation

ssyssy
Copy link
Contributor

@ssyssy ssyssy commented Sep 15, 2023

What changes are proposed in this pull request?

Add datePredicate, i.e.:
lastModifiedDate(2000/01/01, 2023/09/01)

Why are the changes needed?

Customer requirement.

Does this PR introduce any user facing changes?

na

@ssyssy ssyssy requested a review from jja725 September 15, 2023 05:13
jja725
jja725 suggested changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@jja725 jja725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, adding an integration test on the EE side would be helpful.

dora/core/server/master/src/main/java/alluxio/master/predicate/DatePredicate.java Outdated Show resolved Hide resolved
dora/core/server/master/src/test/java/alluxio/master/predicate/DatePredicateTest.java Outdated Show resolved Hide resolved
dora/core/server/master/src/test/java/alluxio/master/predicate/DatePredicateTest.java Outdated Show resolved Hide resolved
@ssyssy ssyssy force-pushed the addFilterType branch 2 times, most recently from 59f672e to 0eb5010 Compare September 17, 2023 02:23
@ssyssy ssyssy requested a review from jja725 September 17, 2023 02:25
jja725
jja725 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@jja725 jja725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jja725 jja725 added the type-feature This issue is a feature request label Sep 18, 2023
@jja725
Copy link
Contributor

jja725 commented Sep 18, 2023

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 838893d into main Sep 18, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jja725 jja725 jja725 approved these changes

Assignees
No one assigned
Labels
type-feature This issue is a feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ssyssy @jja725 @alluxio-bot