Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only stop processes belong to the current user #18187

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

secfree
Copy link
Contributor

@secfree secfree commented Sep 21, 2023

What changes are proposed in this pull request?

Only stop processes belong to the current user while running ./bin/alluxio process start or ./bin/alluxio process stop

Why are the changes needed?

Without this PR, it will try to stop all processes match the class name even they are not started by the current user. Like the below case

$ ./bin/alluxio process stop local
WARN[2023-09-21T14:57:31+08:00] No process to stop because could not find running process matching alluxio.worker.AlluxioWorker
INFO[2023-09-21T14:57:31+08:00] Found 1 running process(es) matching alluxio.master.AlluxioMaster
INFO[2023-09-21T14:57:31+08:00] Successfully killed 0 process(es)
ERRO[2023-09-21T14:57:31+08:00] Failed to kill 1 process(es):
ERRO[2023-09-21T14:57:31+08:00] Failed to kill process: error sending TERM signal to process for alluxio.master.AlluxioMaster with pid 17055
 --- at /tmp/alluxio1717887242/cli/src/alluxio.org/cli/env/process.go:175 (BaseProcess.Stop.func1) ---
Caused by: operation not permitted

Does this PR introduce any user facing changes?

NO

@Xenorith Xenorith added the type-bug This issue is about a bug label Sep 21, 2023
@Xenorith
Copy link
Contributor

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 2e18cd2 into Alluxio:main Sep 21, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug This issue is about a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants