Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve resource deallocation in FUSE #18206

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Improve resource deallocation in FUSE #18206

merged 1 commit into from
Sep 25, 2023

Conversation

jiacheliu3
Copy link
Contributor

@jiacheliu3 jiacheliu3 commented Sep 25, 2023 •
edited
Loading

What changes are proposed in this pull request?

This improves resource deallocation in two ways:

  1. Close FileSystemContext
  2. Close an optional thread pool on normal exit (before it is only destroy on error)

Why are the changes needed?

Resource deallocation

huanghua78
huanghua78 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@huanghua78 huanghua78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jiacheliu3 jiacheliu3 changed the title improve resource deallocation Improve resource deallocation in FUSE Sep 25, 2023
@jiacheliu3 jiacheliu3 added the type-bug This issue is about a bug label Sep 25, 2023
@jiacheliu3
Copy link
Contributor Author

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit fc70ad2 into Alluxio:main Sep 25, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huanghua78 huanghua78 huanghua78 approved these changes

@dbw9580 dbw9580 dbw9580 approved these changes

Assignees
No one assigned
Labels
type-bug This issue is about a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jiacheliu3 @dbw9580 @huanghua78 @alluxio-bot