Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SMALLFIX] Enable one UT case in OutStreamTest #18272

Merged

Conversation

YichuanSun
Copy link
Contributor

What changes are proposed in this pull request?

A comment in OutStreamTest is useless and need to be removed.

Why are the changes needed?

Improve code quality.

Does this PR introduce any user facing changes?

No.

@YichuanSun YichuanSun added the type-code-quality code quality improvement label Oct 16, 2023
Comment on lines -77 to -78
@DoraTestTodoItem(action = DoraTestTodoItem.Action.FIX, owner = "JiamingMai",
comment = "support create out stream with truncate flag")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please take a look @JiamingMai ? Thanks!

Copy link
Contributor

@JiamingMai JiamingMai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacheliu3 jiacheliu3 changed the title Remove useless DoraTestTodoItem in OutStreamTest. [SMALLFIX] Enable one UT case in OutStreamTest Oct 16, 2023
@jiacheliu3
Copy link
Contributor

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit fae6922 into Alluxio:main Oct 16, 2023
14 checks passed
ssz1997 pushed a commit to ssz1997/alluxio that referenced this pull request Dec 15, 2023
### What changes are proposed in this pull request?

A comment in OutStreamTest is useless and need to be removed.

### Why are the changes needed?

Improve code quality.

### Does this PR introduce any user facing changes?

No.

			pr-link: Alluxio#18272
			change-id: cid-602cf0523ed6fbedc30ff448dfb4682006599baa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-code-quality code quality improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants