Fix chaotic chinese characters with golang cli commands #18386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i think the java subprocess should inherit the environment variables from the go CLI process. it does so by default but not when we change the |
Xenorith
approved these changes
Nov 7, 2023
|
alluxio-bot, merge this please |
|
alluxio-bot, cherry-pick this to branch-3-1.1.x please |
alluxio-bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
When debugging load command, it is found that `./bin/alluxio` CLI can't process Chinese characters correctly. There must be something wrong with the CLI encoding or decoding. It seems that the Chinese characters are encoded incorrectly. This happens because the construction of CLI commands does not initialize environmental variables correctly. OS-level environmental variables are ignored, so the program uses a false encoder. This pull request fixes this problem. pr-link: #18386 change-id: cid-a15fb106b4a6cd77087cdbba82e426f1ba1e4b4c
|
Auto cherry-pick to branch |
alluxio-bot
added a commit
that referenced
this pull request
Nov 8, 2023
Cherry-pick of existing commit. orig-pr: #18386 orig-commit: 7d15de7 orig-commit-author: twalluxio <[email protected]> pr-link: #18394 change-id: cid-a15fb106b4a6cd77087cdbba82e426f1ba1e4b4c
ssz1997
pushed a commit
to ssz1997/alluxio
that referenced
this pull request
Dec 15, 2023
When debugging load command, it is found that `./bin/alluxio` CLI can't process Chinese characters correctly. There must be something wrong with the CLI encoding or decoding. It seems that the Chinese characters are encoded incorrectly. This happens because the construction of CLI commands does not initialize environmental variables correctly. OS-level environmental variables are ignored, so the program uses a false encoder. This pull request fixes this problem. pr-link: Alluxio#18386 change-id: cid-a15fb106b4a6cd77087cdbba82e426f1ba1e4b4c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debugging load command, it is found that
./bin/alluxioCLI can't process Chinese characters correctly. There must be something wrong with the CLI encoding or decoding. It seems that the Chinese characters are encoded incorrectly.This happens because the construction of CLI commands does not initialize environmental variables correctly. OS-level environmental variables are ignored, so the program uses a false encoder.
This pull request fixes this problem.