Make WorkerInfo enum (and some small refactors) #18460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbw9580
commented
Dec 6, 2023
| @@ -33,7 +33,7 @@ public final class WorkerInfo implements Serializable { | |||
| private WorkerIdentity mIdentity; | |||
| private WorkerNetAddress mAddress = new WorkerNetAddress(); | |||
| private int mLastContactSec; | |||
| private String mState = ""; | |||
| private WorkerState mState = WorkerState.UNRECOGNIZED; | |||
There was a problem hiding this comment.
I had to assign a default value for worker state. A UNRECOGNIZED state means either the code that creates the WorkerInfo object did not set its state explicitly, or the worker is unknown to the membership service (e.g. never registered).
jiacheliu3
changed the title
jiacheliu3
approved these changes
Dec 7, 2023
| /*** | ||
| * The worker state maintained by master. | ||
| */ | ||
| public enum WorkerState { |
There was a problem hiding this comment.
anchor: moved from dora/core/common/src/main/java/alluxio/master/WorkerState.java
Comment on lines
+83
to
+88
| if (Modifier.isStatic(fieldModifiers) || Modifier.isFinal(fieldModifiers)) { | ||
| continue; | ||
| } | ||
| field.setAccessible(true); | ||
| // set fields in the copy to their default value | ||
| field.set(copied, Defaults.defaultValue(field.getType())); |
|
alluxio-bot, merge this please |
ssz1997
pushed a commit
to ssz1997/alluxio
that referenced
this pull request
Dec 15, 2023
### What changes are proposed in this pull request? 1. Move `WorkerState` enum from master package to the wire package. 2. Add a new worker state `UNRECOGNIZED` and use it as the default state. 3. Make worker state in `WorkerInfo` an enum. 4. Add copy constructors to `WorkerInfo` and `WorkerNetAddress`. ### Why are the changes needed? 1. Make sure the state of worker can be enumerated. 2. Allow safely copying mutable `WorkerInfo` and `WorkerNetAddress` objects. ### Does this PR introduce any user facing changes? No. pr-link: Alluxio#18460 change-id: cid-8daf9c1e3ebe8e862a9b0dabb669c80918f5b8b0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
WorkerStateenum from master package to the wire package.UNRECOGNIZEDand use it as the default state.WorkerInfoan enum.WorkerInfoandWorkerNetAddress.Why are the changes needed?
WorkerInfoandWorkerNetAddressobjects.Does this PR introduce any user facing changes?
No.