Fix alluxio-fuse script for finding fuse pid #18465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuQQiu
approved these changes
Dec 14, 2023
LuQQiu
reviewed
Dec 14, 2023
| @@ -329,7 +329,7 @@ unmount_command() { | |||
| readonly force_kill | |||
|
|
|||
| local fuse_pid | |||
| fuse_pid=$(ps ax -o pid,args | grep [A]lluxioFuse | grep " ${mount_point} " | awk '{print $1}') | |||
| fuse_pid=$(ps ax -o pid,args | grep [A]lluxioFuse | grep " ${mount_point}" | awk '{print $1}') | |||
There was a problem hiding this comment.
this may not help distringuish "/path1" from "/path1/path2"
There was a problem hiding this comment.
actually i know why this isn't working anymore, its bcos of the mnt table mgr change, the start up script transfers from
-m <mount_point> -u <ufs_root_path>
to
m <mount_point>
if mnt table mgr is enabled, hence not working, should find a way to correct this due to mnt table mgr change.
@jiacheliu3 @dbw9580 FYI
There was a problem hiding this comment.
using word boundary for this
lucyge2022
force-pushed
the
alluxio-fuse-script
branch
from
f097c65
to
fa3397a
Compare
LuQQiu
approved these changes
Dec 14, 2023
lucyge2022
changed the title
|
alluxio-bot, merge this please. |
|
merge failed: |
|
alluxio-bot, merge this please. |
ssz1997
pushed a commit
to ssz1997/alluxio
that referenced
this pull request
Dec 15, 2023
### What changes are proposed in this pull request? Remove additional white space in alluxio-fuse script ### Why are the changes needed? alluxio-fuse unmount <mnt_point> is unable to find the pid of AlluxioFuse process because the grep content isn't correct. ### Does this PR introduce any user facing changes? No pr-link: Alluxio#18465 change-id: cid-3e70b0c8edbaa0ba50d744fd6155b0d494a243f9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Remove additional white space in alluxio-fuse script
Why are the changes needed?
alluxio-fuse unmount <mnt_point> is unable to find the pid of AlluxioFuse process because the grep content isn't correct.
Does this PR introduce any user facing changes?
No