Support TOS exception handle in Alluxio #18630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underfs/tos/src/main/java/alluxio/underfs/tos/TOSUnderFileSystemFactory.java
Show resolved
Hide resolved
| errorDescription = cause.getCode() + ":" + cause.getMessage(); | ||
| public static AlluxioTosException from(String errorMessage, TosException cause) { | ||
| Status status = httpStatusToGrpcStatus(cause.getStatusCode()); | ||
| String errorDescription = cause.getCode() + ":" + cause.getMessage(); |
There was a problem hiding this comment.
LOG.warn(errorDescription);
|
alluxio-bot, merge this please |
|
merge failed: |
|
alluxio-bot, merge this please |
Xenorith
pushed a commit
that referenced
this pull request
Jun 24, 2024
### What changes are proposed in this pull request? Modified the exception handling related to Tos. ### Why are the changes needed? 1. Because the exception handling needs to conform to Alluxio's conventions. 2. Some exceptions were not handled previously. ### Does this PR introduce any user facing changes? pr-link: #18630 change-id: cid-3a1c12c6d1d9f2271e0ec13ba83629bbaf9c6850
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Modified the exception handling related to Tos.
Why are the changes needed?
Does this PR introduce any user facing changes?