Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running on early access and beta JDKs #18634

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Jun 25, 2024

What changes are proposed in this pull request?

Right now Alluxio 2.x is not starting correctly on early access/beta JDKs. It's required to do a proper forward testing of new JDK releases.

Why are the changes needed?

Please clarify why the changes are needed. For instance,

  1. If you propose a new API, clarify the use case for a new API.
  2. If you fix a bug, describe the bug.

Does this PR introduce any user facing changes?

Please list the user-facing changes introduced by your change, including

  1. change in user-facing APIs
  2. addition or removal of property keys
  3. webui

@wendigo
Copy link
Contributor Author

wendigo commented Jun 25, 2024

cc @jja725

@jja725 jja725 self-requested a review June 25, 2024 17:53
@wendigo wendigo force-pushed the serafin/fix-version-parsing branch from cfe16ed to c3bb492 Compare June 25, 2024 19:58
@wendigo wendigo requested a review from Xenorith June 25, 2024 20:09
Copy link
Contributor

@jja725 jja725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the effort!

@jja725
Copy link
Contributor

jja725 commented Jun 25, 2024

alluxio-bot, merge this please

@alluxio-bot
Copy link
Contributor

merge failed:
Merge refused because pull request does not have label start with type-

@jja725 jja725 added the type-feature This issue is a feature request label Jun 25, 2024
@jja725
Copy link
Contributor

jja725 commented Jun 25, 2024

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit be7de74 into Alluxio:master-2.x Jun 25, 2024
19 checks passed
@jja725
Copy link
Contributor

jja725 commented Jun 25, 2024

alluxio-bot, cherry-pick this to main please

@alluxio-bot
Copy link
Contributor

Auto cherry-pick unsuccessful Failed to setup local git for auto cherry-pick be7de74 cannot be auto cherry-picked to branch main. Please cherry-pick this manually.

@wendigo wendigo deleted the serafin/fix-version-parsing branch June 26, 2024 10:32
@wendigo
Copy link
Contributor Author

wendigo commented Jun 26, 2024

@jja725 can you release a new version?

@jja725
Copy link
Contributor

jja725 commented Jun 27, 2024

Hi @wendigo , we are having test errors with weird Grpc errors at trinodb/trino#21603, so we are thinking whether we can resolve that in the new release as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-feature This issue is a feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants