Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add get focusx and focusy #32

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

add get focusx and focusy #32

wants to merge 10 commits into from

Conversation

mariopce
Copy link

@mariopce mariopce commented Jan 15, 2019

Add information for rotation where is a focus point
Remove reqTouchScreen to support Samsung Dex


This change is Reviewable

Copy link
Collaborator

@rharter rharter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change. I think it's a good one, but the focus code should live on the parent TwoFingerGestureDetector instead of just the RotateGestureDetector, since they'll all have a focal point.

Also, I realize this old code isn't well formatted, but I'd rather not add to the poor formatting, so please check whitespace, don't leave empty javadoc comments, and group member variables together.

@mariopce
Copy link
Author

Now I think PR could be merged.
Mariusz

Copy link
Author

@mariopce mariopce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants