Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two bug fixs #129

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

two bug fixs #129

wants to merge 27 commits into from

Conversation

Ovear
Copy link

@Ovear Ovear commented Aug 31, 2022

Hi,
There are few bugs a fixed for kemono-dl, please check.

  1. if downloaded file is corrupted(both part file and downloaded file), kemono-dl will keep append to the file untill reach the limit when overwrite mode enable.
  2. if combine --no-part-file and --overwrite options, kemono-dl will try to append to original file and caused mismatched file, which always casued first download attempt failed.

@afterdelight
Copy link

What about corrupted downloaded file? Will it automatically deleted like part file?

@Ovear
Copy link
Author

Ovear commented Sep 1, 2022

What about corrupted downloaded file? Will it automatically deleted like part file?

If overwrite option is used, the final file will be replaced by the part file if verify pass.

@afterdelight
Copy link

could you add the function or command to automatically replace the corrupted file even if overwrite option is not used?

@Ovear
Copy link
Author

Ovear commented Sep 19, 2022

could you add the function or command to automatically replace the corrupted file even if overwrite option is not used?

I will implment this on i get some time.

@afterdelight
Copy link

okay, good to know

@Ovear Ovear mentioned this pull request Sep 29, 2022
@Ovear
Copy link
Author

Ovear commented Sep 29, 2022

Implemented

okay, good to know

@ytoaa
Copy link

ytoaa commented Oct 10, 2022

There are times when files are intentionally damaged and maintained It filters down the files that you download as much as possible through the filter function, but if not, it is deliberately creating and maintaining a file with the same name as 0 bytes. So it would be nice to turn on/off the file corruption detection function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants