GetBranchByVolume #1318
Open
GetBranchByVolume #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please take a look and let me know how we can proceed. |
|
@abessiari Do you know if these changes are now in a release, such as 2.2? |
|
@cyrush It looks like those changes are in vtkm 2.2.0. I will double check by testing against it. I have a doctor's appointment and I will confirm once I am back. Thanks |
|
I thought it was part of VTK-m 2.1 it seems it didn't quite make it.
Should definitely be part of VTK-m 2.2.
Gunther
…On Thu, Aug 22, 2024 at 11:30 AM abessiari ***@***.***> wrote:
@cyrush <https://github.com/cyrush> It looks like those changes are in
vtkm 2.2.0. I will double check by testing against it. I have a doctor's
appointment and I will confirm once I am back.
Thanks
—
Reply to this email directly, view it on GitHub
<#1318 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABPQD6PLT5FTJEM2MOMP4TDZSYU4RAVCNFSM6AAAAABJLB3XTWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBVGM4TANJSHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@cyrush |
Handling multiple domains
abessiari
force-pushed
the
GetBranchByVolume
branch
from
edffaea
to
211c852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changed introduced in https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3157
The changes are as of now in master.