fix: Correction in Rocket.chat documentation (argoproj#18498)

* Replaced email to SAMAccountName Signed-off-by: Raghavi Shirur <[email protected]> Signed-off-by: Raghavi Shirur <[email protected]> * Replaced email to SAMAccountName Signed-off-by: Raghavi Shirur <[email protected]> Signed-off-by: Raghavi Shirur <[email protected]> * Updated go.mod Signed-off-by: Raghavi Shirur <[email protected]> Signed-off-by: Raghavi Shirur <[email protected]> * Revert "Updated go.mod" This reverts commit a646653. Signed-off-by: Raghavi Shirur <[email protected]> Signed-off-by: Raghavi Shirur <[email protected]> * Updated go.mod Signed-off-by: Raghavi Shirur <[email protected]> Signed-off-by: Raghavi Shirur <[email protected]> * Fixed failing CI Signed-off-by: Raghavi Shirur <[email protected]> Signed-off-by: Raghavi Shirur <[email protected]> * Fixed failing CI Signed-off-by: Raghavi Shirur <[email protected]> Signed-off-by: Raghavi Shirur <[email protected]> * Fixed failing CI Signed-off-by: Raghavi Shirur <[email protected]> Signed-off-by: Raghavi Shirur <[email protected]> * Fixed failing CI Signed-off-by: Raghavi Shirur <[email protected]> Signed-off-by: Raghavi Shirur <[email protected]> --------- Signed-off-by: Raghavi Shirur <[email protected]> Signed-off-by: Raghavi Shirur <[email protected]>
AmadeusITGroup · Jun 16, 2024 · 0e4f616 · 0e4f616
1 parent 27792e8
commit 0e4f616
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/docs/operator-manual/notifications/services/github.md b/docs/operator-manual/notifications/services/github.md
@@ -7,7 +7,9 @@ The GitHub notification service changes commit status using [GitHub Apps](https:
 - `appID` - the app id
 - `installationID` - the app installation id
 - `privateKey` - the app private key
-- `enterpriseBaseURL` - optional URL, e.g. https://git.example.com/
+- `enterpriseBaseURL` - optional URL, e.g. https://git.example.com/api/v3
+
+> ⚠️ _NOTE:_ Specifying `/api/v3` in the `enterpriseBaseURL` is required until [argoproj/notifications-engine#205](https://github.com/argoproj/notifications-engine/issues/205) is resolved.
 
 ## Configuration
 

diff --git a/docs/operator-manual/notifications/services/rocketchat.md b/docs/operator-manual/notifications/services/rocketchat.md
@@ -4,7 +4,7 @@
 
 The Rocket.Chat notification service configuration includes following settings:
 
-* `email` - the Rocker.Chat user's email
+* `email` - the Rocker.Chat user's SAMAccountName
 * `password` - the Rocker.Chat user's password
 * `alias` - optional alias that should be used to post message
 * `icon` - optional message icon
@@ -25,7 +25,7 @@ The Rocket.Chat notification service configuration includes following settings:
 4. Copy username and password that you was created for bot user
 5. Create a public or private channel, or a team, for this example `my_channel`
 6. Add your bot to this channel **otherwise it won't work**
-7. Store email and password in argocd_notifications-secret Secret
+7. Store email and password in argocd-notifications-secret Secret
 
 ```yaml
 apiVersion: v1

diff --git a/go.mod b/go.mod
@@ -12,7 +12,7 @@ require (
 	github.com/alicebob/miniredis/v2 v2.30.4
 	github.com/antonmedv/expr v1.15.2
 	github.com/argoproj/gitops-engine v0.7.1-0.20240514190100-8a3ce6d85caa
-	github.com/argoproj/notifications-engine v0.4.1-0.20240403133627-f48567108f01
+	github.com/argoproj/notifications-engine v0.4.1-0.20240606074338-0802cd427621
 	github.com/argoproj/pkg v0.13.7-0.20230626144333-d56162821bd1
 	github.com/aws/aws-sdk-go v1.50.8
 	github.com/bmatcuk/doublestar/v4 v4.6.0

diff --git a/go.sum b/go.sum
@@ -697,8 +697,8 @@ github.com/apache/thrift v0.16.0/go.mod h1:PHK3hniurgQaNMZYaCLEqXKsYK8upmhPbmdP2
 github.com/appscode/go v0.0.0-20191119085241-0887d8ec2ecc/go.mod h1:OawnOmAL4ZX3YaPdN+8HTNwBveT1jMsqP74moa9XUbE=
 github.com/argoproj/gitops-engine v0.7.1-0.20240514190100-8a3ce6d85caa h1:RcIYoAbkaGA7yzpY1YItaTLgKYABDfkITyQ4jUl3Y6c=
 github.com/argoproj/gitops-engine v0.7.1-0.20240514190100-8a3ce6d85caa/go.mod h1:Vet2xN0akQpggQJZGmThA8Lozpn26RLagZFmLXw/oSI=
-github.com/argoproj/notifications-engine v0.4.1-0.20240403133627-f48567108f01 h1:/V8+HM0VPPTrdjTwUrkIj5a+SjaU//tJwfIXJ1QAOvg=
-github.com/argoproj/notifications-engine v0.4.1-0.20240403133627-f48567108f01/go.mod h1:N0A4sEws2soZjEpY4hgZpQS8mRIEw6otzwfkgc3g9uQ=
+github.com/argoproj/notifications-engine v0.4.1-0.20240606074338-0802cd427621 h1:Yg1nt+D2uDK1SL2jSlfukA4yc7db184TTN7iWy3voRE=
+github.com/argoproj/notifications-engine v0.4.1-0.20240606074338-0802cd427621/go.mod h1:N0A4sEws2soZjEpY4hgZpQS8mRIEw6otzwfkgc3g9uQ=
 github.com/argoproj/pkg v0.13.7-0.20230626144333-d56162821bd1 h1:qsHwwOJ21K2Ao0xPju1sNuqphyMnMYkyB3ZLoLtxWpo=
 github.com/argoproj/pkg v0.13.7-0.20230626144333-d56162821bd1/go.mod h1:CZHlkyAD1/+FbEn6cB2DQTj48IoLGvEYsWEvtzP3238=
 github.com/armon/circbuf v0.0.0-20150827004946-bbbad097214e/go.mod h1:3U/XgcO3hCbHZ8TKRvWD2dDTCfh9M9ya+I9JpbB7O8o=