-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for LoongArch64 #17
Conversation
If Amanieu was willing, a new feature for nightly-only #![cfg_attr(feature = "nightly-arch", feature(asm_experimental_arch))] and this to Cargo.toml, under # enable experimental nightly features
nightly-arch = [] And then gating Of course, I am not Amanieu, so I do not know if he is willing. However, it seemed better to suggest it as an alternative to waiting for the stabilization timeframe to elapse, as that might prove longer than desired. My apologies if it is not a welcome suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall!
For CI support, my recommendation would be to add a loongarch target to cross which works for Tier 3 targets.
Regarding inline asm, I think it's fine to wait for it to become stable since it's not too far off. If you need support sooner, I'm also happy to add it under an optional feature like @workingjubilee suggests.
Hey @Amanieu, could it be possible to get this reviewed/merged soon? Thanks! |
@heiher This PR is still marked as a draft, but I believe it is ready for review? |
Nice! |
Published. |
Thank you. |
This PR is depends on the stable inline asm to unblock builds. All tests and benchmarks are passed. We will add CI support after LoongArch64 is promoted to Tier 2.