Update use of libc::timespec to prepare for future libc version
#363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why this is failing on |
|
All rustc versions before 1.54 are broken with the latest XCode version as the linker no longer accepts non-object files in archives. rust-lang/rust#84449 which landed in 1.54 started wrapping the crate metadata in an object file. See rust-lang/rust#103044 for more info. |
|
CI should be fixed now, can you rebase? |
In a future release of the `libc` crate, `libc::timespec` will contain private padding fields on `*-linux-musl` targets and so the struct will no longer be able to be created using the literal initialization syntax. Update the use of `libc::timespec` to create a value by calling `std::mem::zeroed()` first and then setting the `tv_sec` and `tv_nsec` fields manually which works with both current versions of `libc` as well as the future version which contains that change.
wesleywiser
force-pushed
the
update_timespec_init
branch
from
7fec6a7
to
246ec6d
Compare
|
Sure, rebased! |
|
Looks like CI is green! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a future release of the
libccrate,libc::timespecwill contain private padding fields on 32-bit*-linux-musltargets and so the struct will no longer be able to be created using the literal initialization syntax.Update the use of
libc::timespecto create a value by callingstd::mem::zeroed()first and then setting thetv_secandtv_nsecfields manually which works with both current versions oflibcas well as the future version which contains that change.See also rust-lang/libc#2088