remove Address.sol, replace isContract with address(...).code.length > 0 #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
代码编译无法通过，最好不要使用内联汇编，这样会增加读者学习代码的成本 |
XdpCs
requested changes
Nov 7, 2024
| @@ -13,8 +12,6 @@ import "../34_ERC721/IERC165.sol"; | |||
| * 见 https://eips.ethereum.org/EIPS/eip-1155 | |||
| */ | |||
| contract ERC1155 is IERC165, IERC1155, IERC1155MetadataURI { | |||
| using Address for address; // 使用Address库，用isContract来判断地址是否为合约 | |||
| using Strings for uint256; // 使用Strings库 | |||
| } else { | ||
| /// @solidity memory-safe-assembly | ||
| assembly { | ||
| revert(add(32, reason), mload(reason)) |
|
如果大佬没空修改的话，明天我会在你这个分支上修改完，进行合并 |
|
这个我回退一下版本就行，是merge Main的时候导致的错误，至于内联汇编哪里，我主要参考的是https://github.com/AmazingAng/WTF-Solidity/blob/main/34_ERC721/ERC721.sol |
好的 辛苦了 我最近比较忙 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this (这是什么类型的PR)
Which issue(s) this PR fixes(Optional) (这个PR 修复了什么问题 (可选择))
What this PR does / why we need it (这个PR 做了什么/ 我们为什么需要这个PR)
to.isContract()报错