-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: hiddenActivityBanners #1060
Conversation
…g the check banner
src/controllers/activity/activity.ts
Outdated
/* eslint-disable @typescript-eslint/no-floating-promises */ | ||
this.#storage.set('hiddenActivityBanners', this.#hiddenActivityBanners) | ||
|
||
this.emitUpdate() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can call emitUpdate
and await storage set afterwards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, but I don't understand why should we do that? For example, in removeAccountData
, we do the same as here: no awaits, first setting the storage and only after that updating
…ow-manual-activity-banner-hide
…ow-manual-activity-banner-hide
…ow-manual-activity-banner-hide
Add: hiddenActivityBanners to activity.ts to allow for manually hiding the activity banner
This is the main change: