-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created function for Install-Winget #18
Conversation
@tobraha I'm trying to figure out how to assign this to you... |
You should be able to just request a review from me instead of assigning the whole PR to me. You would normally use 'Assignees' for issues rather than pull requests. |
I believe you'd need write access to be marked as a reviewer. |
Running some tests and received the following errors. Keep in mind that I did run our old decrapifier script on my Win10 VM before you fixed it. PowerShell Core (7.1.3):
PowerShell (5.1.19041.906)
Fiddled with this for a while until I finally tried manually downloading the appxbundle and double-clicking it, which then led to this prompt: That installed "Microsoft Visual C++ 2015 UWP Desktop Runtime Package" from the store... and then Install-WinGet worked! Also of note:When running
So its invocation to see if it's already installed will fail if run as admin... Seems to be an known issue for recent releases of Windows 10 (reference: microsoft/winget-cli#637) I'd say we can go ahead and merge this, but we'll need to keep that elevated privs issue in mind if we try to utilize this in any scripts. |
Added dependency checks Repaired PWSH install
@tobraha Only issue I'm seeing now is we can't work with appxpackages from our RMM agent, since it's running as system. |
If (WGVersion -ne $WGVersion2) turned into If ($WGVersion -ne $WGVersion2)
No description provided.