Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty list check (fix name pop errors) #53

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

Ainaemaet
Copy link
Contributor

Just a quick and easy fix to avoid the 'pop from empty list' errors that show up in terminal when no device is connected; keeping terminal info cleaner (and avoiding people getting worried about errors, and helping those with us who are a bit OCD from not having to make manual code edits each time we get an update).

Fixes this error particularly:
"[ERROR] An error occurred while retrieving information for the 'STREAM READER (JOV) 📺' node.
Traceback (most recent call last):
File "/home/my_path/ComfyUI/server.py", line 486, in get_object_info
out[x] = node_info(x)
^^^^^^^^^^^^
File "/home/my_path/ComfyUI/server.py", line 455, in node_info
info['input_order'] = {key: list(value.keys()) for (key, value) in obj_class.INPUT_TYPES().items()}
^^^^^^^^^^^^^^^^^^^^^^^
File "/home/my_path/ComfyUI/custom_nodes/Jovimetrix/core/device_stream.py", line 86, in INPUT_TYPES
names.pop()
IndexError: pop from empty list"

Copy link
Owner

@Amorano Amorano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid! thanks!

@Amorano Amorano merged commit a6eacba into Amorano:main Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants