Empty list check (fix name pop errors) #53
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick and easy fix to avoid the 'pop from empty list' errors that show up in terminal when no device is connected; keeping terminal info cleaner (and avoiding people getting worried about errors, and helping those with us who are a bit OCD from not having to make manual code edits each time we get an update).
Fixes this error particularly:
"[ERROR] An error occurred while retrieving information for the 'STREAM READER (JOV) 📺' node.
Traceback (most recent call last):
File "/home/my_path/ComfyUI/server.py", line 486, in get_object_info
out[x] = node_info(x)
^^^^^^^^^^^^
File "/home/my_path/ComfyUI/server.py", line 455, in node_info
info['input_order'] = {key: list(value.keys()) for (key, value) in obj_class.INPUT_TYPES().items()}
^^^^^^^^^^^^^^^^^^^^^^^
File "/home/my_path/ComfyUI/custom_nodes/Jovimetrix/core/device_stream.py", line 86, in INPUT_TYPES
names.pop()
IndexError: pop from empty list"