Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts/vsmlrt.py: update esrgan janai models #53

Merged
merged 1 commit into from
Jun 25, 2023
Merged

scripts/vsmlrt.py: update esrgan janai models #53

merged 1 commit into from
Jun 25, 2023

Conversation

hooke007
Copy link
Contributor

@hooke007 hooke007 commented Jun 23, 2023 •
edited
Loading

Remove old models and add v2 ones

models-1.zip
AnimeJaNai_v2 : RealESRGANv2\{animejanaiV2L1, animejanaiV2L2, animejanaiV2L3}.onnx

@WolframRhodium
Copy link
Contributor

Thanks! Could you explain why backward compatibility is not preserved?

@hooke007
Copy link
Contributor Author

Do you mean "why remove old models"?
New models fix defects in old ones, I do not think keeping the old ones is a good idea.

@WolframRhodium
Copy link
Contributor

What about starting the value of animejanaiV2 from 5005?

@hooke007
Copy link
Contributor Author

Hmm, and leave the 5000-5004 empty?

@WolframRhodium
Copy link
Contributor

Yep.

@WolframRhodium WolframRhodium merged commit b20fc6e into AmusementClub:master Jun 25, 2023
@WolframRhodium
Copy link
Contributor

Thanks!

WolframRhodium pushed a commit that referenced this pull request Jun 25, 2023
@hooke007 @WolframRhodium
scripts/vsmlrt.py: update esrgan janai models (#53)
f513109
@hooke007 hooke007 deleted the janaiV2 branch June 26, 2023 10:18
@Ironclad17
Copy link

So what are the differences between L1, L2; L3? Do they correspond to Compact, UltraCompact; SuperUltraCompact respectively?

@hooke007
Copy link
Contributor Author

hooke007 commented Aug 6, 2023

L1 → fp32 SuperUltraCompact
L3 → fp32 Compact

@WolframRhodium WolframRhodium mentioned this pull request Oct 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hooke007 @WolframRhodium @Ironclad17