Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Configure callback #118

Closed
staff0rd opened this issue Nov 18, 2021 · 2 comments
Closed

Feature: Configure callback #118

staff0rd opened this issue Nov 18, 2021 · 2 comments

Comments

@staff0rd
Copy link
Contributor

staff0rd commented Nov 18, 2021

I'd like to attempt to make the hardcoded callback url (http://localhost:3000) for openid implicit to be configurable. Is this a feature you'd be interested in merging were I to open a PR?

At the very least, I'd expect to be able to use something like --callback http://localhost:8653/whatever/path or similar via CLI option and the http server to respect this.

@AnWeber
Copy link
Owner

AnWeber commented Nov 18, 2021

The change would also affect the VSCode extension. Therefore, when starting the server, it would be necessary to check whether a server has already been opened on this port and to reuse it if necessary. This makes it necessary to manage the servers that have been started.
To customize the path, the logic for recognizing the callback call must be adjusted.

I actually don't mind features that extend functionality. However, backwards compatibility should always be taken into account (if possible).

@AnWeber
Copy link
Owner

AnWeber commented Nov 30, 2021

The pull request I have just published with the new version

@AnWeber AnWeber closed this as completed Nov 30, 2021
AnWeber added a commit to httpyac/httpyac.github.io that referenced this issue Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants