Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to receive auth token w/ oauth2 client credentials flow results in exit code 0 #760

Closed
tyler-hagen opened this issue Aug 1, 2024 · 2 comments

Comments

@tyler-hagen
Copy link

tyler-hagen commented Aug 1, 2024

I have some tests running in a pipeline, and ended up configuring and invalid client_id/client_secret. This resulted in a 401 response from the auth server, which I can see in the logs.

I expected the behavior to be that all my tests that reference the prefix with the invalid client_id and client_secret would be failed tests, and therefore the process would exit with some sort of error code that my pipeline runner could recognize as a failure. Because the behavior is to just essentially skip the test and not count it as a pass or fail, and exit successfully, I was not able to recognize my tests were not being run for some time.

I'm not sure if this is actually an issue or if I'm misusing the tool. Any suggestions?

@AnWeber
Copy link
Owner

AnWeber commented Aug 2, 2024

Hi, the behavior is indeed not good. I have adjusted it and generate an error status in this case as well. The case did not throw an exception and was simply canceled directly and therefore generated the skipped status. Since I have revised the procedure as part of another ticket, I will include your issue there directly. It should be fixed with the next release.

@AnWeber AnWeber closed this as completed Aug 2, 2024
@tyler-hagen
Copy link
Author

Thank you @AnWeber ! Please let me know if I can help in any way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants