Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http header and content-type completion is broken since v6.1.0 #223

Closed
bigsan opened this issue Sep 18, 2023 · 2 comments
Closed

http header and content-type completion is broken since v6.1.0 #223

bigsan opened this issue Sep 18, 2023 · 2 comments

Comments

@bigsan
Copy link

bigsan commented Sep 18, 2023

Because of the completion items in src/provider/httpCompletionItemProvider.ts were removed, instead it tries to load from plugins/http/completionItemProvider.ts in httpyac modules which was not imported anywhere in that module.

The index.ts under http, eventsource and websocket plugins in httypyac module didn't contain import "./completionItemProvider", which causes this problem.

I don't know if that was intentional or a bug, hope this can be fixed soon 😀.
@AnWeber
Copy link
Owner

AnWeber commented Sep 18, 2023 •
edited
Loading

@bigsan I haven't fully understood what's broken. You have a commit for me because you seem to have already identified the code.

Well, maybe I’ve already understood it. yes, it seems to be an issue.

AnWeber added a commit to AnWeber/httpyac that referenced this issue Sep 18, 2023
@AnWeber
fix: reenable Http Header completion (AnWeber/vscode-httpyac#223)
cbafb12
AnWeber added a commit that referenced this issue Sep 18, 2023
@AnWeber
fix: reenable Http Header completion (#223)
ad1ed67
@AnWeber
Copy link
Owner

AnWeber commented Sep 18, 2023

fixed. with v6.6.7

@AnWeber AnWeber closed this as completed Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bigsan @AnWeber