Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] scrutiny uses wrong unit for drive capacity #330

Closed
dom6770 opened this issue Jul 10, 2022 · 3 comments · Fixed by #352
Closed

[BUG] scrutiny uses wrong unit for drive capacity #330

dom6770 opened this issue Jul 10, 2022 · 3 comments · Fixed by #352
Labels
bug Something isn't working

Comments

@dom6770
Copy link

dom6770 commented Jul 10, 2022

Describe the bug
The displayed unit in the webinterface for drive capacity is wrong. It displays base 1000 units (GB) although the calculated size is base 1024.
It's the same issue with Windows, which also calculates with base 1042, but uses base 1000 units.
So, scrutiny calculates with base 1024, but does not use base 1042 units, which should be f.ex. Gibibyte (GiB).

Expected behavior
Either

a) calculate with base 1000 and display base 1000 (500 GB)
b) calculate with base 1024 and display base 1024 (465 GiB)

Preferably, let the user decide in the settings.

Screenshots
image

Same in Windows:
image

smartctl reports the capacity correctly
image

@dom6770 dom6770 added the bug Something isn't working label Jul 10, 2022
@AnalogJ
Copy link
Owner

AnalogJ commented Jul 10, 2022

you're not wrong, but when I added the humanize code I didn't think people would care.

KB ~= KiB for most people.

I'll make a note to make it configurable via something like this: https://stackoverflow.com/a/14919494

@Panzer1119
Copy link

KB ~= KiB for most people.

Maybe, but GB and GiB already differ a little bit more, and TB and TiB can make a huge difference e.g. 18 (TB) vs 16.37 (TiB)

@AnalogJ
Copy link
Owner

AnalogJ commented Aug 4, 2022

v0.5.0 has been released and fixes this issue via a dropdown in the Dashboard settings panel! Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants