Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration files with yml extension #472

Merged

Conversation

adamantike
Copy link
Contributor

If a collector.yml or scrutiny.yml configuration file is present, use it as long as a .yaml version is not available too.

Fixes #79

If a `collector.yml` or `scrutiny.yml` configuration file is present,
use it as long as a `.yaml` version is not available too.

Fixes AnalogJ#79
@codecov-commenter
Copy link

Codecov Report

Merging #472 (932e191) into master (0febe3f) will decrease coverage by 1.77%.
The diff coverage is 1.92%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
- Coverage   32.54%   30.78%   -1.77%     
==========================================
  Files          54       29      -25     
  Lines        3045     2706     -339     
  Branches       66        0      -66     
==========================================
- Hits          991      833     -158     
+ Misses       2018     1843     -175     
+ Partials       36       30       -6     
Flag Coverage Δ
unittests 30.78% <1.92%> (-1.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
webapp/backend/pkg/config/config.go 0.00% <0.00%> (ø)
webapp/backend/pkg/database/scrutiny_repository.go 11.65% <0.00%> (-0.96%) ⬇️
...end/pkg/database/scrutiny_repository_migrations.go 0.00% <0.00%> (ø)
webapp/backend/pkg/web/server.go 62.26% <100.00%> (-4.41%) ⬇️

... and 25 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AnalogJ AnalogJ changed the base branch from master to beta April 7, 2023 00:45
@AnalogJ
Copy link
Owner

AnalogJ commented Apr 7, 2023

Thanks for the PR @adamantike !
Haha this issue has been open for a while, thanks for picking it up.

@AnalogJ AnalogJ merged commit d76cdca into AnalogJ:beta Apr 7, 2023
@adamantike adamantike deleted the misc/add-support-for-yml-config-files branch April 7, 2023 00:48
@AnalogJ AnalogJ mentioned this pull request Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support both .yml and .yaml for config file in default path.
3 participants