-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebase docker image to debian 12 (bookworm) #596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR! 🥳
made a couple of comments -- mostly just questions
docker/Dockerfile
Outdated
"arm64") S6_ARCH=aarch64 ;; \ | ||
esac \ | ||
&& update-ca-certificates | ||
RUN case ${TARGETARCH} in \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason you wanted to split up this RUN into multiple steps?
Is this a leftover from debugging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I was trying to figure out if it was the apt command or curl command causing the problem. It can be combined into a single line again.
I can make the necessary changes, but would that require a new pull request? |
Nope, no new pull request required. Just make changes in your existing branch, the PR will be updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes were made based on previous comments. Specifically, recombining split RUN command from Dockerfile and adding apt list clean up as per Docker imaging building best practices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
broken curl
command -- but other than that, everything else looks good.
thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #596 +/- ##
==========================================
- Coverage 32.54% 31.48% -1.06%
==========================================
Files 54 29 -25
Lines 3045 2763 -282
Branches 66 0 -66
==========================================
- Hits 991 870 -121
+ Misses 2018 1854 -164
- Partials 36 39 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
docker image is now based on debian 12 bookworm so smartmontools is now 7.3.
to resolve [BUG] Could not retrieve device information #538
#538