Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase docker image to debian 12 (bookworm) #596

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

dropsignal
Copy link
Contributor

docker image is now based on debian 12 bookworm so smartmontools is now 7.3.
to resolve [BUG] Could not retrieve device information #538
#538

Copy link
Owner

@AnalogJ AnalogJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR! 🥳
made a couple of comments -- mostly just questions

"arm64") S6_ARCH=aarch64 ;; \
esac \
&& update-ca-certificates
RUN case ${TARGETARCH} in \
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason you wanted to split up this RUN into multiple steps?
Is this a leftover from debugging?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I was trying to figure out if it was the apt command or curl command causing the problem. It can be combined into a single line again.

docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile.collector Outdated Show resolved Hide resolved
@dropsignal
Copy link
Contributor Author

I can make the necessary changes, but would that require a new pull request?

@AnalogJ
Copy link
Owner

AnalogJ commented Mar 9, 2024

Nope, no new pull request required. Just make changes in your existing branch, the PR will be updated.

Copy link
Contributor Author

@dropsignal dropsignal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes were made based on previous comments. Specifically, recombining split RUN command from Dockerfile and adding apt list clean up as per Docker imaging building best practices.

docker/Dockerfile Outdated Show resolved Hide resolved
Copy link
Owner

@AnalogJ AnalogJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broken curl command -- but other than that, everything else looks good.

@AnalogJ
Copy link
Owner

AnalogJ commented Mar 13, 2024

thanks!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.48%. Comparing base (0febe3f) to head (6a9b89b).
Report is 96 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #596      +/-   ##
==========================================
- Coverage   32.54%   31.48%   -1.06%     
==========================================
  Files          54       29      -25     
  Lines        3045     2763     -282     
  Branches       66        0      -66     
==========================================
- Hits          991      870     -121     
+ Misses       2018     1854     -164     
- Partials       36       39       +3     
Flag Coverage Δ
unittests 31.48% <ø> (-1.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AnalogJ AnalogJ merged commit a0f9e6e into AnalogJ:master Mar 13, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants