Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tiles in VR mode (regression w.r.t. Cesium 1.44) #6612

Closed
glathoud opened this issue May 22, 2018 · 7 comments
Closed

Missing tiles in VR mode (regression w.r.t. Cesium 1.44) #6612

glathoud opened this issue May 22, 2018 · 7 comments

Comments

@glathoud
Copy link
Contributor

Hello, sometimes in VR mode some tiles are not displayed. From what I could see, the issue happens with Cesium 1.45 but not with Cesium 1.44.

To reproduce the issue:

  • open the Sandcastle example "Ground Clamping"
  • add the line vrButton: true to the Viewer config
  • re-run the example, click on the VR button and move the camera around (see the screenshots below).

I also tried scene.logarithmicDepthBuffer = false but that did not change the behaviour.

Below, you can see the code, and screenshots taken with Cesium v1.44 and v1.45 at similar positions.
If I can do anything to further help, please let me know.

Screenshots

Code with vrButton: true:
code_cesium145


Position 1, Cesium 1.44:
position1_cesium144
...vs Cesium 1.45:
position1_cesium145


Position 2, Cesium 1.44:
position2_cesium144
...vs Cesium 1.45:
position2_cesium145

@mramato
Copy link
Contributor

mramato commented May 22, 2018

This is most likely a dupe of #3812, which has been around for quite some time. It might have gotten worse in the latest release though (perhaps log Z related?) CC @bagnell

@glathoud
Copy link
Contributor Author

Here is an example for a 1280x1024 screen device. Just click on the VR button and shortly after the camera will be moved to a problematic (position,direction) pair. Problem reproduced with a chromium browser under Lubuntu.

@glathoud
Copy link
Contributor Author

Using that example the issue seems to appear in the master branch at the log depth merge 50b1d5d, and not on the previous commit 603640c

However in my tests, setting viewer.scene.logarithmicDepthBuffer = false; did not change the result.

@glathoud
Copy link
Contributor Author

Here is a possible fix that makes the aspectRatio in configureCameraFrustum depend on useWebVR. In my tests it worked.

@glathoud
Copy link
Contributor Author

glathoud commented Jun 5, 2018

Hello, it would be cool if someone could have a short look on the two small commits below and say whether they are worth submitting a PR.

@hpinkos
Copy link
Contributor

hpinkos commented Jun 5, 2018

Hi @glathoud! I'm not super familiar with this area of the code, but your fix make sense to me. It would be great if you can open a PR with that fix! Thanks!

@glathoud
Copy link
Contributor Author

glathoud commented Jun 6, 2018

@hpinkos thanks for looking at the code. I just created the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants