Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing tiles in VR #6798

Merged
merged 3 commits into from
Jul 12, 2018
Merged

Fix missing tiles in VR #6798

merged 3 commits into from
Jul 12, 2018

Conversation

bagnell
Copy link
Contributor

@bagnell bagnell commented Jul 12, 2018

The line here was the problem:
d681755#diff-6298b280e4e0977bedd881b65b769863L3232

The setup for each view for the eye was expecting the frustum to be a reference.

Fixes #6612.

@cesium-concierge
Copy link

cesium-concierge commented Jul 12, 2018

Thanks for the pull request @bagnell!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV. (NA)
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@lilleyse
Copy link
Contributor

Thanks, this fixes it.

@lilleyse lilleyse merged commit af2e382 into master Jul 12, 2018
@lilleyse lilleyse deleted the vr-fix-mising-tiles branch July 12, 2018 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants