Regex search #3287
Regex search #3287
Conversation
| @@ -142,7 +143,7 @@ android { | |||
| /** these config values override those in AndroidManifest.xml. Can also set versionCode and versionName */ | |||
| defaultConfig { | |||
| applicationId = applicationIdStandard | |||
| minSdk = 23 | |||
| minSdk = 26 | |||
There was a problem hiding this comment.
Not sure, I'll check what breaks if I put it back
There was a problem hiding this comment.
MethodHandle.invoke and MethodHandle.invokeExact are only supported starting with Android O (--min-api 26): Lorg/tartarus/snowball/SnowballProgram;find_among([Lorg/tartarus/snowball/Among;I)I
There was a problem hiding this comment.
This is rather conserning in my opinion. We will drop support from very big amount of mobile phones if we drop android 6 and 7. Maybe we need to release two versions, one for old phones and one for new phones if we will merge this...
- I will check and analyze play store statistics.
| @@ -34,7 +34,6 @@ buildscript { | |||
| val jvmToolChainVersion by extra(17) | |||
| val coreKtxVersion by extra("1.13.1") | |||
| val sqliteAndroidVersion by extra("3.42.0") | |||
| val jswordVersion by extra("2.4.14") | |||
There was a problem hiding this comment.
submodule requires CI stuff to be working also, will consider if I fix them or drop submodule stuff from here (of course help appreciated if possible).
There was a problem hiding this comment.
I'll have a look next week to see if I can get the pipelines running correctly.
There was a problem hiding this comment.
could also be something chatgpt will give us with a simple prompt
| /** can we enable the main menu search button | ||
| */ | ||
| override val isSearchable: Boolean | ||
| get() = try { //TODO allow japanese search - japanese bibles use smartcn which is not available | ||
| !currentDocument!!.doesNotExist && "ja" != currentDocument!!.language.code |
There was a problem hiding this comment.
- todo: check japanese documents
There was a problem hiding this comment.
I performed a quick check by copy-pasting part of the document and searching for it, which worked. But I don't speak/read Japanese, so I don't know if the results made any sense.
There was a problem hiding this comment.
I will try to consult my friend chatgpt. He speaks japanese for sure 😊
|
|
Describe the pull request content
I added a regular expression search option.
To do this, I had to update Apache Lucene 5 major versions (from 3.6 to 8.11). I tested several languages and searching still works, however testing by native speakers might be necessary. Depends on AndBible/jsword#15. After merging, it might be necessary to invalidate the indexes for all documents.
Screenshots