Check if hiddenTextarea is in current body #292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In situations where the
document.body
was replaced, the check ifhiddenTextarea.parentNode === null
would returnfalse
even if in fact the newdocument.body
had no currenthiddenTextarea
, thus requiring a new one to be appended. The new logic checks if!document.body.contains(hiddenTextarea)
, which should account for the currentdocument.body
.An alternative solution would be to check if
hiddenTextarea.isConnected
, which is probably more performant. Unfortunately, this property is not present in IE.Yet another solution which might be more performant at the expense of being more verbose, is to recursively check if
hiddenTextarea.parentNode === null
to confirm that it's in fact still in the current DOM tree.Fixes #247