Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context document #20

Merged
merged 3 commits into from
Nov 21, 2015
Merged

Context document #20

merged 3 commits into from
Nov 21, 2015

Conversation

AndersDJohnson
Copy link
Owner

Contexts now dereference on the root of the document to which they belong, rather than on their own (sub-)node or any parent context(s).

I believe this behavior was the intent of the changes by @slavaschmidt for parent context dereferencing in #15. @slavaschmidt, can you see if this branch passes your use cases?

P.S. This behavior may have to change if we ever implement relative pointers per #19.

@codecov-io
Copy link

Current coverage is 76.99%

Merging #20 into master will increase coverage by +1.42% as of 102c1cd

@@            master     #20   diff @@
======================================
  Files            6       6       
  Stmts          217     213     -4
  Branches        33      31     -2
  Methods          0       0       
======================================
  Hit            164     164       
+ Partial         12      11     -1
+ Missed          41      38     -3

Review entire Coverage Diff as of 102c1cd

Powered by Codecov. Updated on successful CI builds.

@AndersDJohnson
Copy link
Owner Author

Still pending tests with self-references in referenced external documents.

@slavaschmidt
Copy link
Contributor

@adjohnson916 Thanks for fixing that. These are exactly the changes I was mentioning. I can't test all of the use cases but I'll check at least these I have and report the results. Sorry, this will take a day or two because of the current state of the play-swagger branch I'm integrating with.

@AndersDJohnson
Copy link
Owner Author

@slavaschmidt Thanks, keep me updated if you can.

AndersDJohnson pushed a commit that referenced this pull request Nov 21, 2015
@AndersDJohnson AndersDJohnson merged commit e46bc67 into master Nov 21, 2015
AndersDJohnson pushed a commit that referenced this pull request Nov 21, 2015
@AndersDJohnson AndersDJohnson deleted the context-document branch March 29, 2019 00:15
AndersDJohnson added a commit that referenced this pull request Apr 8, 2019
AndersDJohnson added a commit that referenced this pull request Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants