Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed warnings & deprecated issues #151

Merged
merged 2 commits into from
Mar 2, 2024

Conversation

dehlirious
Copy link
Contributor

Solution: Turn ${var} to {$var} , instead of using $json use false.

PHP message: PHP Deprecated:  Using ${var} in strings is deprecated, use {$var} instead in index.php on line 102; 
PHP message: PHP Deprecated:  Using ${var} in strings is deprecated, use {$var} instead in index.php on line 112; 
PHP message: PHP Deprecated:  Using ${var} in strings is deprecated, use {$var} instead in index.php on line 113; 
PHP message: PHP Warning:  Undefined variable $json in index.php on line 27"

@AndrewPaglusch
Copy link
Owner

@dehlirious Thanks for the PR! I'll reply back here after we've had a chance to review it.

@dehlirious
Copy link
Contributor Author

@dehlirious Thanks for the PR! I'll reply back here after we've had a chance to review it.

Awesome. Any chance you'd open a discussions section on this repo?

@AndrewPaglusch AndrewPaglusch linked an issue Mar 2, 2024 that may be closed by this pull request
Copy link
Owner

@AndrewPaglusch AndrewPaglusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. Working good

@AndrewPaglusch AndrewPaglusch merged commit c925ae9 into AndrewPaglusch:master Mar 2, 2024
1 check passed
@AndrewPaglusch
Copy link
Owner

@dehlirious I forgot to mention: I opened discussions! Thanks for the suggestion

@dehlirious dehlirious deleted the pr branch March 9, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP Undefined Variable Warning
2 participants