Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3 中國八大菜系: 川菜、湘菜、粵菜、閩菜、蘇菜、浙菜、徽菜和魯菜 #252

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#3 中國八大菜系: 川菜、湘菜、粵菜、閩菜、蘇菜、浙菜、徽菜和魯菜 #252

wants to merge 1 commit into from

Conversation

LinMingQiang
Copy link

No description provided.

Anduin2017
Anduin2017 requested changes Feb 22, 2022
View reviewed changes
Copy link
Owner

@Anduin2017 Anduin2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在还没分类，一旦合并这个PR，就导致readme不可读了

@wmswu
Copy link

wmswu commented Feb 22, 2022

我认为不需要分类了，只有去餐馆才要分菜系，这里统称为家常菜就够了，除非要写成厨师培训班...

@LinMingQiang
Copy link
Author

我认为不需要分类了，只有去餐馆才要分菜系，这里统称为家常菜就够了，除非要写成厨师培训班...

不分类的话，之后菜品太多比较难管理。同时如果暂时不知道做什么，但明确是想要做某个菜系(例如川菜)，有分类的话方便查找

@LinMingQiang
Copy link
Author

现在还没分类，一旦合并这个PR，就导致readme不可读了

啊？为什么会导致readme不可读，这个pr没有冲突应该不影响

@recolic
Copy link
Collaborator

recolic commented Feb 22, 2022

我认为需要先在这个issue中进行讨论。因为很多人都希望使用各种各样不同的标准进行分类，而用这种方案，无法同时兼容多种分类方法。 #109

@cmsax
Copy link

cmsax commented Apr 7, 2022

可以考虑扩展一个可选的 tags 字段而非强制性地对菜品按照菜系划分。划分菜系对 How-To-Cook 意义不大

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anduin2017 Anduin2017 Anduin2017 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LinMingQiang @wmswu @recolic @cmsax @Anduin2017